Ensuring that GtRefactoryChangeManager captures all change events immediately after startup#17
Open
kilian-kier wants to merge 1 commit intofeenkcom:mainfrom
Open
Ensuring that GtRefactoryChangeManager captures all change events immediately after startup#17kilian-kier wants to merge 1 commit intofeenkcom:mainfrom
kilian-kier wants to merge 1 commit intofeenkcom:mainfrom
Conversation
|
[This is an automated comment from the feenk Contributor License Agreement robot.] Hello kilian-kier! Thanks for your interest in making software development better. Please sign the feenk Contributor License Agreement so we can investigate merging in your work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the GtRefactoryChangeManager singleton was lazily initialized, meaning it wouldn't start subscribing to announcements until it was first accessed. We encountered that most events were missed because of this. Now it ensures that a singleton instance is present at image startup, which means it should always be subscribed to the change events